Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add is_active to institution model #73

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

lchen-2101
Copy link
Collaborator

closes #70

Copy link

Coverage report

The coverage rate went from 86.64% to 86.44% ⬇️
The branch rate is 85%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

src/entities/models/dao.py

100% of new lines are covered (100% of the complete file).

src/entities/models/dto.py

100% of new lines are covered (100% of the complete file).

src/entities/repos/institutions_repo.py

100% of new lines are covered (97.01% of the complete file).

src/routers/institutions.py

100% of new lines are covered (100% of the complete file).

Copy link
Contributor

@jcadam14 jcadam14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@lchen-2101 lchen-2101 merged commit 219a8ae into main Dec 28, 2023
3 checks passed
@lchen-2101 lchen-2101 deleted the feature/70_add_active_field_to_institution_model branch December 28, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add active field to institutions model
2 participants